fix(core): discover vendor directory first on all platforms #1535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The vendor directory is string matched to give it the lowest priority when loading configuration files during discovery. This change sets the prefixed and suffixed directory separator to the PHP constant DIRECTORY_SEPARATOR rather than hard-coding '/'. This allows the match to work when PHP is running on Windows - which uses '\' as a directory separator - as well as on other platforms.
TheRealMrG
changed the title
innocenzi
changed the title
Member
|
Awesome, thanks! |
Bapawe
pushed a commit
to Bapawe/tempest-framework
that referenced
this pull request
Aug 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The vendor directory is string matched to give it the lowest priority when loading configuration files during discovery. This change sets the prefixed and suffixed directory separator to the PHP constant DIRECTORY_SEPARATOR rather than hard-coding '/'. This allows the match to work when PHP is running on Windows (which uses '' as a directory separator), as well as on other platforms.
Resolves #1526